Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 31004: Have tld_cleanup generate a .cc file that contains the effective (Closed)

Created:
11 years, 10 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Dean McNamee
Visibility:
Public.

Description

Have tld_cleanup generate a .cc file that contains the effective tld data. This makes the build dependencies easier (helpful for grit and gyp) and brings in the effective tld data on mac. BUG=6076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3702 lines, -126 lines) Patch
A net/base/effective_tld_names.cc View 1 chunk +3654 lines, -0 lines 0 comments Download
M net/base/net_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M net/base/registry_controlled_domain.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/registry_controlled_domain.cc View 2 chunks +1 line, -22 lines 0 comments Download
M net/build/convert_tld_data.rules View 1 chunk +0 lines, -19 lines 0 comments Download
M net/build/net.vcproj View 4 chunks +1 line, -12 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 6 chunks +6 lines, -2 lines 0 comments Download
M net/net_lib.scons View 1 chunk +1 line, -1 line 0 comments Download
M net/net_resources.scons View 1 chunk +1 line, -57 lines 0 comments Download
A net/tools/tld_cleanup/README View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 5 chunks +32 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
It would be nice to eventually not have to parse the effective tld data (i.e., ...
11 years, 10 months ago (2009-02-23 23:55:49 UTC) #1
Pam (message me for reviews)
Scons and XCode changes largely rubber-stamped; the rest LGTM assuming the unit test still passes ...
11 years, 10 months ago (2009-02-24 00:07:37 UTC) #2
tony
11 years, 10 months ago (2009-02-24 00:13:18 UTC) #3
On 2009/02/24 00:07:37, Pam wrote:
> Scons and XCode changes largely rubber-stamped; the rest LGTM assuming the
unit
> test still passes and isn't too slow with this larger set of default data.


tc@master-shake /src/chrome/src/chrome %./Hammer/net_unittests
--gtest_filter=Reg\* --gtest_print_time
Note: Google Test filter = Reg*
[==========] Running 5 tests from 1 test case.
<snip>
[----------] 5 tests from RegistryControlledDomainTest (172 ms total)

I think 172ms is ok.

Powered by Google App Engine
This is Rietveld 408576698