Issue 3099: Changed the disassembler formatting...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3099: Changed the disassembler formatting... (Closed)

Created:
12 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed the disassembler formatting Changed the formatting of the comment in the disassembler output to contain more information on code targets. Committed: http://code.google.com/p/v8/source/detail?r=327

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -37 lines)			Patch
M	src/disassembler.cc	View	1	1 chunk	+54 lines, -37 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/3099/diff/1/2 File src/disassembler.cc (right): http://codereview.chromium.org/3099/diff/1/2#newcode266 Line 266: RelocInfo::RelocModeName(rmode)); The indentation looks funny here? http://codereview.chromium.org/3099/diff/1/3 ...

12 years, 3 months ago (2008-09-17 12:27:11 UTC) #2

Søren Thygesen Gjesse

12 years, 3 months ago (2008-09-17 12:37:06 UTC) #3

http://codereview.chromium.org/3099/diff/1/2
File src/disassembler.cc (right):

http://codereview.chromium.org/3099/diff/1/2#newcode266
Line 266: RelocInfo::RelocModeName(rmode));
On 2008/09/17 12:27:11, Kasper Lund wrote:
> The indentation looks funny here?

Fixed.

http://codereview.chromium.org/3099/diff/1/3
File src/objects.cc (right):

http://codereview.chromium.org/3099/diff/1/3#newcode4192
Line 4192: const char* Code::ICState2String(InlineCacheState ic_state) {
On 2008/09/17 12:27:11, Kasper Lund wrote:
> Rename ic_state to state?

Renamed.

http://codereview.chromium.org/3099/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/3099/diff/1/4#newcode2066
Line 2066: static const char* ICState2String(InlineCacheState ic_state);
On 2008/09/17 12:27:11, Kasper Lund wrote:
> I would just call the parameter 'state'.

Renamed.

Expand Messages | Collapse Messages