Issue 3096008: A follow-up to r5211: fix a couple of issues detected on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3096008: A follow-up to r5211: fix a couple of issues detected on Windows. (Closed)

Created:
10 years, 4 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

A follow-up to r5211: fix a couple of issues detected on Windows. - storage of enums in bit fields; - removing dead entries from address -> id map in HeapObjectsMap; - layout of HeapEntry, to avoid class size increase on ia32 due to alignment; Committed: http://code.google.com/p/v8/source/detail?r=5217

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	src/profile-generator.h	View		4 chunks	+7 lines, -7 lines	2 comments	Download
	M	src/profile-generator.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/3096008/diff/1/3 File src/profile-generator.h (right): http://codereview.chromium.org/3096008/diff/1/3#newcode579 src/profile-generator.h:579: uint64_t id_; Could we have a STATIC_ASSERT on ...

10 years, 4 months ago (2010-08-09 14:44:10 UTC) #2

mnaganov (inactive)

10 years, 4 months ago (2010-08-09 15:18:37 UTC) #3

http://codereview.chromium.org/3096008/diff/1/3
File src/profile-generator.h (right):

http://codereview.chromium.org/3096008/diff/1/3#newcode579
src/profile-generator.h:579: uint64_t id_;
On 2010/08/09 14:44:10, Søren Gjesse wrote:
> Could we have a STATIC_ASSERT on sizeof(HeapEntry)? Or maybe a simple cctest?

OK, will do this as a separate commit.

Expand Messages | Collapse Messages