Issue 3091004: Various bug fixes to tpm_lite. Some changes to the test suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3091004: Various bug fixes to tpm_lite. Some changes to the test suite. (Closed)

Created:
10 years, 4 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Various bug fixes to tpm_lite. Some changes to the test suite.

Patch Set 2 : . #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
M	Makefile	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	firmware/lib/tpm_lite/tlcl.c	View	1	4 chunks	+19 lines, -2 lines	1 comment	Download
M	firmware/stub/tpm_lite_stub.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/tpm_lite/enable.c	View		1 chunk	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

http://codereview.chromium.org/3091004/diff/1/2 File Makefile (right): http://codereview.chromium.org/3091004/diff/1/2#newcode37 Makefile:37: make -C utility update_tlcl_structures; \ Make sure tlcl_structures.h is ...

10 years, 4 months ago (2010-08-04 01:20:35 UTC) #1

Randall Spangler

10 years, 4 months ago (2010-08-04 16:27:26 UTC) #5

http://codereview.chromium.org/3091004/diff/2001/3002
File firmware/lib/tpm_lite/tlcl.c (right):

http://codereview.chromium.org/3091004/diff/2001/3002#newcode71
firmware/lib/tpm_lite/tlcl.c:71: printf("command: %x%x %x%x%x%x %x%x%x%x\n",
Better to use VBDEBUG here, so that we can turn on EXTRA_LOGGING inside the
firmware (which doesn't have printf())

Expand Messages | Collapse Messages

Issue 3091004: Various bug fixes to tpm_lite. Some changes to the test suite. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages