Issue 3089004: Mac: Some clang appeasing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3089004: Mac: Some clang appeasing. (Closed)

Created:
10 years, 4 months ago by Nico

Modified:
10 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, apatrick_chromium, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Evan Martin

Visibility:
Public.

Description

Mac: Some clang appeasing. BUG=TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54870

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -34 lines)			Patch
M	base/string_piece.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_model.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bubble_controller.mm	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_button.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_button.mm	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/fullscreen_controller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/fullscreen_controller.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/ev_bubble_decoration.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/popup_blocked_animation_mac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/net/gaia/token_service.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/gaia/token_service.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/default_plugin/plugin_impl_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/default_plugin/plugin_impl_mac.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/default_plugin/plugin_impl_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/cookie_monster.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/mime_sniffer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/http/http_auth_gssapi_posix.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/ext/canvas_paint_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/glue_serialize.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages