Issue 3087009: add pepper video decoder glue and delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3087009: add pepper video decoder glue and delegate (Closed)

Created:
10 years, 4 months ago by wjia(left Chromium)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

add pepper video decoder glue and delegate BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55252

Patch Set 1 #

Patch Set 2 : merge with TOT #

Total comments: 2

Patch Set 3 : change Flush() interface, update DEPS #

Patch Set 4 : reload #

Patch Set 5 : merge with TOT #

Patch Set 6 : reload #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+317 lines, -2 lines)			Patch
M	DEPS	View	1 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/pepper_plugin_delegate_impl.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/pepper_plugin_delegate_impl.cc	View	1 2	2 chunks	+96 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_delegate.h	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_video_decoder.h	View	1 2	1 chunk	+49 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_video_decoder.cc	View	1 2	1 chunk	+140 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

There could be some issue about how PP_CompletionCallback is used in Flush(). If Flush() has ...

10 years, 4 months ago (2010-08-04 21:52:28 UTC) #1

brettw

10 years, 4 months ago (2010-08-05 19:57:21 UTC) #2

LGTM

http://codereview.chromium.org/3087009/diff/3001/4006
File webkit/glue/plugins/pepper_video_decoder.cc (right):

http://codereview.chromium.org/3087009/diff/3001/4006#newcode25
webkit/glue/plugins/pepper_video_decoder.cc:25: PluginInstance* instance =
PluginInstance::FromPPInstance(instance_id);
It might be nice to set *num_configs to 0 before doing anything in case the
plugin forgets to check the return value.

http://codereview.chromium.org/3087009/diff/3001/4006#newcode124
webkit/glue/plugins/pepper_video_decoder.cc:124: void
VideoDecoder::Flush(PP_CompletionCallback& callback) {
I think you should return int32 from here for consistency. Then return
PP_ERROR_WOULDBLOCK which is how we signal that the completion callback will
complete asynchronously.

Expand Messages | Collapse Messages