Added HostKeyPair class, signatures for heartbeat messages.

remoting/host/host_key_pair.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_HOST_KEY_PAIR_H_
+#define REMOTING_HOST_HOST_KEY_PAIR_H_
+
+#include <vector>
+#include <string>
+
+#include "base/ref_counted.h"
+#include "base/scoped_ptr.h"
+
+namespace base {
+class RSAPrivateKey;
+}

[awong, 2010/08/02 19:53:49]

namespace :P

[Sergey Ulanov, 2010/08/03 02:10:39]

Done.

+
+namespace remoting {
+
+class HostConfig;
+class MutableHostConfig;
+
+class HostKeyPair : public base::RefCountedThreadSafe<HostKeyPair> {

[awong, 2010/08/02 19:53:49]

Does this thing really need to be refcounted?  Do we actually need shared
lifetime semantics between multiple threads?

[Sergey Ulanov, 2010/08/03 02:10:39]

The only reason it needs to be ref-counted is because we need to create a Task
for DoSave() when writing config. I would love to get rid this refcounter, if
only we could create Tasks for objects that are not refcounted.

[awong, 2010/08/03 19:21:02]

Ah!  we solved that!

See the DISABLE_RUNNABLE_METHOD_REFCOUNT() inside base/task.h.

Use it like

  DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::HostKeyPair);

declared outside the namespace.

+ public:
+  HostKeyPair();
+  virtual ~HostKeyPair();

[awong, 2010/08/02 19:53:49]

The HearbeatSender class didn't have a virtual destructor.  Do we need to
specify a virtual destructor for RefCountedThreadSafe classes?  I thought there
was a precedent in Chrome to not make the destructor virtual if that's the only
parent and we don't expect descendents preferring instead to make the destructor
private and friending the RefCountedThreadSafe class... see
webkit/glue/plugins/plugin_instance.h for example.

[Sergey Ulanov, 2010/08/03 02:10:39]

removed it.

+
+  void Generate();
+  bool LoadFromString(const std::string& key_base64);
+  bool Load(HostConfig* host_config);
+  void Save(MutableHostConfig* host_config);
+
+  std::string GetPublicKey() const;
+  std::string GetSignature(const std::string& message) const;
+
+ private:
+  void DoSave(MutableHostConfig* host_config) const;
+
+  scoped_ptr<base::RSAPrivateKey> key_;
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_HOST_KEY_PAIR_H_