Issue 3086018: Don't run base/WMI* tests under Dr. Memory due to crashes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3086018: Don't run base/WMI* tests under Dr. Memory due to crashes... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, brettw-cc_chromium.org, Timur Iskhodzhanov, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run base/WMI* tests under Dr. Memory due to crashes TBR=glider BUG=http://code.google.com/p/drmemory/issues/detail?id=21 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55045

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	base/data/valgrind/base_unittests.gtest-drmemory_win32.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-12 07:34:26 UTC) #2

LGTM

On Thu, Aug 5, 2010 at 1:22 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't run base/WMI* tests under Dr. Memory due to crashes
> TBR=glider
> BUG=http://code.google.com/p/drmemory/issues/detail?id=21
>
> Please review this at http://codereview.chromium.org/3086018/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/data/valgrind/base_unittests.gtest-drmemory_win32.txt
>
>
> Index: base/data/valgrind/base_unittests.gtest-drmemory_win32.txt
> ===================================================================
> --- base/data/valgrind/base_unittests.gtest-drmemory_win32.txt  (revision
> 55038)
> +++ base/data/valgrind/base_unittests.gtest-drmemory_win32.txt  (working
> copy)
> @@ -1,3 +1,7 @@
> +# Dr. Memory crashes on some COM calls:
> +# http://code.google.com/p/drmemory/issues/detail?id=21
> +WMI*
> +
>  # TODO(timurrrr) investigate the failures and enable these tests
> one-by-one.
>  RSA*
>  GmockTest.*
>
>
>

Expand Messages | Collapse Messages