Issue 3086: * Change output of trace_event log to JSON to enable easier integration with ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3086: * Change output of trace_event log to JSON to enable easier integration with ... (Closed)

Created:
12 years, 3 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

* Change output of trace_event log to JSON to enable easier integration with visualization UI. * Simple (manual) trace visualizer with some sample data. * a few more trace events * add process_util function for current process handle Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2381

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1407 lines, -15 lines)			Patch
M	base/process_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/process_util_posix.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/process_util_win.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/trace_event.h	View		7 chunks	+14 lines, -5 lines	0 comments	Download
M	base/trace_event.cc	View	1	7 chunks	+20 lines, -6 lines	0 comments	Download
M	net/base/tcp_client_socket.cc	View		5 chunks	+6 lines, -4 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View		2 chunks	+19 lines, -0 lines	0 comments	Download
A	tools/trace/trace.html	View		1 chunk	+287 lines, -0 lines	0 comments	Download
A	tools/trace/trace_data.js	View		1 chunk	+1050 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

(The HTML file is not really review quality, but given it's just a demo, I ...

12 years, 3 months ago (2008-09-16 17:52:28 UTC) #1

Mike Belshe

lgtm http://codereview.chromium.org/3086/diff/10/212 File tools/trace/trace_data.js (right): http://codereview.chromium.org/3086/diff/10/212#newcode1 Line 1: var raw_trace_events = [ I'm guessing you ...

12 years, 3 months ago (2008-09-18 20:25:55 UTC) #2

Erik does not do reviews

12 years, 3 months ago (2008-09-18 20:42:05 UTC) #3

http://codereview.chromium.org/3086/diff/10/212
File tools/trace/trace_data.js (right):

http://codereview.chromium.org/3086/diff/10/212#newcode1
Line 1: var raw_trace_events = [
On 2008/09/18 20:25:55, mbelshe wrote:
> I'm guessing you don't want to really check this in?

The plan was for this to be just some sample data so if someone wanted to play
with the trace code they could do it without having to generate a new trace on
their own.

Expand Messages | Collapse Messages