Issue 3085015: Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3085015: Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest. (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, John Grabowski, Paul Godavari, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest. TBR=thakis TEST=unit_tests BUG=48913, 21479 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55094

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/cocoa/download_util_mac_unittest.mm	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/test/data/valgrind/unit_tests.gtest_mac.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years, 4 months ago (2010-08-05 17:57:54 UTC) #3

We now have a real DownloadUtilTest which is using TEST macro. That one was
using TEST_F and the same test name. It's illegal to mix TEST with TEST_F,
but it's difficult to spot when they're in different files.

On Thu, Aug 5, 2010 at 10:56, <thakis@chromium.org> wrote:

> LG I guess, but how/why does this help?
>
>
> http://codereview.chromium.org/3085015/show
>

Expand Messages | Collapse Messages