Issue 3084027: Clean up code by removing network traffic code in network library....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3084027: Clean up code by removing network traffic code in network library.... (Closed)

Created:
10 years, 4 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
joth

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clean up code by removing network traffic code in network library. We are no longer using the code. If we decide that we need it later, we will likely do something different. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55432

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -264 lines)			Patch
M	chrome/browser/chromeos/cros/network_library.h	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	5 chunks	+2 lines, -93 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/internet_options_handler.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/network_message_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/network_state_notifier.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/options/internet_page_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	2 chunks	+0 lines, -153 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

joth

10 years, 4 months ago (2010-08-09 18:40:08 UTC) #2

LGTM.

I'll merge this into my CL once you've landed this one.
Thanks!

Expand Messages | Collapse Messages