Issue 3084012: Move overlay_list to bin/cros_overlay_list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3084012: Move overlay_list to bin/cros_overlay_list. (Closed)

Created:
10 years, 4 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
piman, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Move overlay_list to bin/cros_overlay_list. This conforms to the new layout of scripts in which all scripts other than make_chroot and enter_chroot are installed in the chroot using an ebuild.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	A +	bin/cros_overlay_list	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

10 years, 4 months ago (2010-08-03 17:48:10 UTC) #2

LGTM. Thanks

On Tue, Aug 3, 2010 at 10:43 AM, <robotboy@chromium.org> wrote:

> Reviewers: anush, piman,
>
> Description:
> Move overlay_list to bin/cros_overlay_list.
>
> This conforms to the new layout of scripts in which all scripts
> other than make_chroot and enter_chroot are installed in the
> chroot using an ebuild.
>
> Please review this at http://codereview.chromium.org/3084012/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  A + bin/cros_overlay_list
>
>
> Index: bin/cros_overlay_list
> diff --git a/overlay_list b/bin/cros_overlay_list
> similarity index 98%
> rename from overlay_list
> rename to bin/cros_overlay_list
> index
>
73b8570e25ea60a216d2eae6b597e946741e1156..5aeb2d49cea3e4865dc35a91f714d23cdf327e6d
> 100755
> --- a/overlay_list
> +++ b/bin/cros_overlay_list
> @@ -8,7 +8,7 @@
>
>  # Load common constants.  This should be the first executable line.
>  # The path to common.sh should be relative to your script's location.
> -. "$(dirname "$0")/common.sh"
> +. "$(dirname "$0")/../common.sh"
>
>  get_default_board
>
>
>
>

Expand Messages | Collapse Messages