Issue 3084011: Mange ciricular reference to HttpNetworkTransaction in HttpProxyClientSocktPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3084011: Mange ciricular reference to HttpNetworkTransaction in HttpProxyClientSocktPool. (Closed)

Created:
10 years, 4 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Mange ciricular reference to HttpNetworkTransaction in HttpProxyClientSocktPool. Without explicit management of the cirucular reference to HttpNetworkTransaction, it can get deleted at inopportune times and cause undesirable effects (i.e. triggering a pool to delete itself while in the middle of other operations). This change breaks the cirucular reference at points in execution where it is safe. BUG=50822, 49254 TEST=green reliability bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54715

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	net/http/http_proxy_client_socket_pool.cc	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Issue 3084011: Mange ciricular reference to HttpNetworkTransaction in HttpProxyClientSocktPool. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Simpler fix #

Patch Set 3 : Improve comment #

Messages