PyAuto test for renderer crash reporting

PyAuto test for renderer crash reporting

- Add a helper class (ExistingPathReplacer) to temporarily back up a path while pyauto uses it, and then reinstate it. Used by crash reporter test

- Increase PyAuto's default logging level to INFO

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56906

[John Grabowski, 2010-08-09 20:00:03]

http://codereview.chromium.org/3083028/diff/1/2
File chrome/test/functional/crash_reporter.py (right):

http://codereview.chromium.org/3083028/diff/1/2#newcode27
chrome/test/functional/crash_reporter.py:27: if pyauto.PyUITest.IsMac():
Windows:
http://superuser.com/questions/624/where-is-google-chrome-crash-dump-located
Linux: http://code.google.com/p/chromium/wiki/LinuxCrashDumping

http://codereview.chromium.org/3083028/diff/1/2#newcode27
chrome/test/functional/crash_reporter.py:27: if pyauto.PyUITest.IsMac():
Don't just fill in blank; return early if not mac else test will fail.

http://codereview.chromium.org/3083028/diff/1/4
File chrome/test/pyautolib/pyauto_utils.py (right):

http://codereview.chromium.org/3083028/diff/1/4#newcode39
chrome/test/pyautolib/pyauto_utils.py:39: assert path_type in ('file', 'dir'),
'Invalid path_type: %s' % path_type
it's easy to figure it out yourself so no need for a path_type arg.
Even if not exist it's easy to figure out how to "undo" it.

[Nirnimesh, 2010-08-20 18:34:48]

I fixed the value of chrome::DIR_CRASH_DUMPS on Mac (, so I can now ask chrome
what the dump dir is.

Thanks

http://codereview.chromium.org/3083028/diff/1/2
File chrome/test/functional/crash_reporter.py (right):

http://codereview.chromium.org/3083028/diff/1/2#newcode27
chrome/test/functional/crash_reporter.py:27: if pyauto.PyUITest.IsMac():
On 2010/08/09 20:00:03, John Grabowski wrote:
> Don't just fill in blank; return early if not mac else test will fail.
> 

Done.

http://codereview.chromium.org/3083028/diff/1/2#newcode27
chrome/test/functional/crash_reporter.py:27: if pyauto.PyUITest.IsMac():
On 2010/08/09 20:00:03, John Grabowski wrote:
> Windows:
> http://superuser.com/questions/624/where-is-google-chrome-crash-dump-located
> Linux: http://code.google.com/p/chromium/wiki/LinuxCrashDumping
> 

Done.
Added plumbing to fetch crash dump dir from chrome.

http://codereview.chromium.org/3083028/diff/1/4
File chrome/test/pyautolib/pyauto_utils.py (right):

http://codereview.chromium.org/3083028/diff/1/4#newcode39
chrome/test/pyautolib/pyauto_utils.py:39: assert path_type in ('file', 'dir'),
'Invalid path_type: %s' % path_type
On 2010/08/09 20:00:03, John Grabowski wrote:
> it's easy to figure it out yourself so no need for a path_type arg.
> Even if not exist it's easy to figure out how to "undo" it.
> 
> 

I want to create the existing path too. If path_type is not given and the
requested path doesn't already exist there's no way to figure out if I want a
dir or a file.

http://codereview.chromium.org/3083028/diff/10001/11001
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/3083028/diff/10001/11001#newcode110
chrome/app/breakpad_mac.mm:110: PathService::Override(chrome::DIR_CRASH_DUMPS,
dir_crash_dumps);
Linux and win has chrome::DIR_CRASH_DUMPS set correctly. Mac does not.
This fixes it.

I discussed this with Mark and he suggested this as the right place to do it.

[Nirnimesh, 2010-08-20 18:44:04]

Added some tests for pyauto_utils.

Also, please ignore the comments in chrome/app/breakpad_mac.mm in the previous
mail. I had removed that file from this CL.

[John Grabowski, 2010-08-20 19:37:23]

LGTM

http://codereview.chromium.org/3083028/diff/25001/26003
File chrome/test/functional/crash_reporter.py (right):

http://codereview.chromium.org/3083028/diff/25001/26003#newcode29
chrome/test/functional/crash_reporter.py:29: logging.warn('Cannot figure crash
dir. Bailing out.')
make an error?

http://codereview.chromium.org/3083028/diff/25001/26003#newcode33
chrome/test/functional/crash_reporter.py:33: dmp_files =
glob.glob(os.path.join(breakpad_folder, '*.dmp'))
Do we need to wait for anything here?
Specifically, does NavigateToURL() wait adequately for the crash to finish
dumping before returning?

[Nirnimesh, 2010-08-20 19:51:00]

http://codereview.chromium.org/3083028/diff/25001/26003
File chrome/test/functional/crash_reporter.py (right):

http://codereview.chromium.org/3083028/diff/25001/26003#newcode29
chrome/test/functional/crash_reporter.py:29: logging.warn('Cannot figure crash
dir. Bailing out.')
On 2010/08/20 19:37:23, John Grabowski wrote:
> make an error?
> 

Done.

http://codereview.chromium.org/3083028/diff/25001/26003#newcode33
chrome/test/functional/crash_reporter.py:33: dmp_files =
glob.glob(os.path.join(breakpad_folder, '*.dmp'))
On 2010/08/20 19:37:23, John Grabowski wrote:
> Do we need to wait for anything here?
> Specifically, does NavigateToURL() wait adequately for the crash to finish
> dumping before returning?

Apparently it does wait.