Issue 3083018: [GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3083018: [GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button (Closed)

Created:
10 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button BUG=51325 TEST=showing home button in gtk+ should work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55159

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

10 years, 4 months ago (2010-08-05 23:10:05 UTC) #2

LGTM

On Thu, Aug 5, 2010 at 3:40 PM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> Now I am become Death
>
> Description:
> [GTK] undo more toolbar destruction - unbreak GTK+ theme mode home button
>
> BUG=51325
> TEST=showing home button in gtk+ should work
>
> Please review this at http://codereview.chromium.org/3083018/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/browser/gtk/browser_toolbar_gtk.cc
>
>
> Index: chrome/browser/gtk/browser_toolbar_gtk.cc
> diff --git a/chrome/browser/gtk/browser_toolbar_gtk.cc
> b/chrome/browser/gtk/browser_toolbar_gtk.cc
> index
>
c935aa858fe01598fa58b01813f5e74bf42fee43..0afc3c8c9b616442b1d29ccefb079afac7b1495d
> 100644
> --- a/chrome/browser/gtk/browser_toolbar_gtk.cc
> +++ b/chrome/browser/gtk/browser_toolbar_gtk.cc
> @@ -172,7 +172,8 @@ void BrowserToolbarGtk::Init(Profile* profile,
>                      0);
>
>   home_.reset(new CustomDrawButton(GtkThemeProvider::GetFrom(profile_),
> -      IDR_HOME, IDR_HOME_P, IDR_HOME_H, 0, NULL));
> +      IDR_HOME, IDR_HOME_P, IDR_HOME_H, 0, GTK_STOCK_HOME,
> +      GTK_ICON_SIZE_SMALL_TOOLBAR));
>   gtk_widget_set_tooltip_text(home_->widget(),
>       l10n_util::GetStringUTF8(IDS_TOOLTIP_HOME).c_str());
>   g_signal_connect(home_->widget(), "clicked",
>
>
>

Expand Messages | Collapse Messages