Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 3082008: Updated sync_build_test to use new unit test script. (Closed)

Created:
10 years, 4 months ago by raymes
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, asharif1
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

Updated sync_build_test to use new unit test script. I believe it only makes sense to run this for an x86 target but I might be wrong.

Patch Set 1 #

Patch Set 2 : Fixed long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sync_build_test.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
10 years, 4 months ago (2010-07-30 20:22:59 UTC) #1
asharif1
On 2010/07/30 20:22:59, raymes wrote: > Not sure if it goes over the 80 char ...
10 years, 4 months ago (2010-07-31 00:20:55 UTC) #2
kmixter1
LGTM, I had a CL for this that hadn't landed: http://codereview.chromium.org/2856056/show Did you push this? ...
10 years, 4 months ago (2010-08-02 20:31:19 UTC) #3
raymes
10 years, 4 months ago (2010-08-02 20:37:29 UTC) #4
On Mon, Aug 2, 2010 at 1:36 PM, Raymes Khoury <raymes@chromium.org> wrote:

> I haven't pushed. Should I?
>
>
> On Mon, Aug 2, 2010 at 1:31 PM, Ken Mixter <kmixter@chromium.org> wrote:
>
>> LGTM, I had a CL for this that hadn't landed:
>>
>> http://codereview.chromium.org/2856056/show
>>
>> Did you push this?
>>
>> On Fri, Jul 30, 2010 at 5:20 PM,  <asharif@chromium.org> wrote:
>> > On 2010/07/30 20:22:59, raymes wrote:
>> >
>> >
>> > Not sure if it goes over the 80 char line limit.
>> >
>> > LGTM.
>> >
>> > http://codereview.chromium.org/3082008/show
>> >
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698