Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 3082006: Update the Valgrind/VEX versions for Snow Leopard to 11243/1997... (Closed)

Created:
10 years, 4 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, John Grabowski, Mark Mentovai
Visibility:
Public.

Description

Update the Valgrind/VEX versions for Snow Leopard to 11243/1997 This should fix the problems with the ui_tests on 10.6 (bug 48888) fork.patch doesn't apply to the recent Valgrind versions (starting with 11209), so I had to fork it for Snow Leopard (see fork.10.6.patch) Note: this change does not affect any Valgrind/ThreadSanitizer binaries on any platforms except Mac OS 10.6 BUG=48888 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -3 lines) Patch
M binaries/mac_10.6/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/default.supp View 1 chunk +20 lines, -0 lines 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M scripts/build-memcheck-for-chromium.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/common.sh View 1 chunk +6 lines, -1 line 0 comments Download
A scripts/fork.10.6.patch View 1 chunk +419 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
10 years, 4 months ago (2010-07-30 12:08:06 UTC) #1
Timur Iskhodzhanov
10 years, 4 months ago (2010-07-30 12:30:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698