Issue 3082001: Add a new feature define ENABLE_BLOB....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3082001: Add a new feature define ENABLE_BLOB.... (Closed)

Created:
10 years, 4 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
levin

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a new feature define ENABLE_BLOB. We need to replace all blob related feature defines ENABLE_BLOB_SLICE and ENABLE_FILE_READER. This patch only adds the new feature define in order to be prepared for the corresponding WebKit patch to land. After it is brought down, we will then remove 2 obsolete feature defines. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54770

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/features_override.gypi	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

levin

http://codereview.chromium.org/3082001/diff/1/2 File build/features_override.gypi (right): http://codereview.chromium.org/3082001/diff/1/2#newcode15 build/features_override.gypi:15: 'ENABLE_BLOB_SLICE=1', Why do we still have BLOB_SLICE here? (I ...

10 years, 4 months ago (2010-07-28 20:21:20 UTC) #2

LGTM

Expand Messages | Collapse Messages