Issue 3082: Rename flags.defs to flag-definitions.h....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3082: Rename flags.defs to flag-definitions.h.... (Closed)

Created:
12 years, 3 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Christian Plesner Hansen, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Rename flags.defs to flag-definitions.h. - Add better support for ignoring files in the presubmit tool. Committed: http://code.google.com/p/v8/source/detail?r=322

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -322 lines)
A +	src/flag-definitions.h	View	0 chunks	+-1 lines, --1 lines	0 comments
M	src/flags.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/flags.cc	View	2 chunks	+3 lines, -3 lines	0 comments
D	src/flags.defs	View	1 chunk	+0 lines, -318 lines	0 comments
M	tools/presubmit.py	View	2 chunks	+8 lines, -1 line	0 comments

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 3 months ago (2008-09-16 14:30:44 UTC) #1

Kasper, I renamed the flags.defs file as we discussed and excluded it in the
presubmit tool.

Christian, can you please review if I did update the presubmit.py tool
correctly?

Thanks,
-Ivan

Expand Messages | Collapse Messages