Implemented getActiveAttrib, getActiveUniform and readPixels. Removed...

Implemented getActiveAttrib, getActiveUniform and readPixels. Removed
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29632

[Ken Russell (switch to Gerrit), 2009-10-20 20:09:53]

Please review. Thanks.

[darin (slow to review), 2009-10-20 20:38:23]

just some minor webkit style issues.  otherwise, LGTM (fix these and then check
in)

http://codereview.chromium.org/308006/diff/1/2
File webkit/api/src/GraphicsContext3D.cpp (right):

http://codereview.chromium.org/308006/diff/1/2#newcode1304
Line 1304: if (program == NULL)
nit: use 0 instead of NULL in webkit code.

actually, webkit style for these is to do "if (!program)":
http://webkit.org/coding/coding-style.html

http://codereview.chromium.org/308006/diff/1/2#newcode1772
Line 1772: if (!((format == GL_RGBA) &&
nit: webkit style would not line break here

http://codereview.chromium.org/308006/diff/1/2#newcode1774
Line 1774: return NULL;
nit: use 0 instead of NULL in webkit code

[Ken Russell (switch to Gerrit), 2009-10-21 10:48:25]

http://codereview.chromium.org/308006/diff/1/2
File webkit/api/src/GraphicsContext3D.cpp (right):

http://codereview.chromium.org/308006/diff/1/2#newcode1304
Line 1304: if (program == NULL)
On 2009/10/20 20:38:23, darin wrote:
> nit: use 0 instead of NULL in webkit code.
> 
> actually, webkit style for these is to do "if (!program)":
> http://webkit.org/coding/coding-style.html

Done.

http://codereview.chromium.org/308006/diff/1/2#newcode1772
Line 1772: if (!((format == GL_RGBA) &&
On 2009/10/20 20:38:23, darin wrote:
> nit: webkit style would not line break here

Done.

http://codereview.chromium.org/308006/diff/1/2#newcode1774
Line 1774: return NULL;
On 2009/10/20 20:38:23, darin wrote:
> nit: use 0 instead of NULL in webkit code

Done.