Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3080040: Revert 55259 - FBTF: New IPC definitions, only applied to async ROUTED and CO... (Closed)

Created:
10 years, 4 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
erg
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, brettw-cc_chromium.org, jam, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin-cc_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Revert 55259 - FBTF: New IPC definitions, only applied to async ROUTED and CONTROL messages. The slowest cc files in chrome include render_messages.h and other IPC message definitions. Including one of these files will bring in half of chrome because in the IPC system previously required full class definitions due to implementation details. The new system allows forward declarations and places the implementations of functions that need the full class definitions (ctor/dtor()/Log() and superclass ctor/Read() methods) into a separate xxx_messages.cc file using a parallel set of macros to ipc_message_macros.h. This has the added benefit of moving most of the template instantiation junk into a small number of files. Pros: - Will speed up compiling by a lot once everything is forward declared. - Already, intermediary .o/.a files are smaller. Cons: - Adds a 4th pass to the messages system, this time in a different header. BUG=51411 TEST=none Review URL: http://codereview.chromium.org/2873090 TBR=erg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -867 lines) Patch
M base/tuple.h View 10 chunks +108 lines, -156 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +1 line, -6 lines 0 comments Download
D chrome/browser/importer/importer_messages.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_common.gypi View 7 chunks +1 line, -9 lines 0 comments Download
M chrome/common/common_param_traits.h View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/common/devtools_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/gpu_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/nacl_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/nacl_messages_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/plugin_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/render_messages.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +2 lines, -3 lines 0 comments Download
D chrome/common/service_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/utility_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/worker_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/automation/automation_messages.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ipc/ipc_message_impl_macros.h View 1 chunk +0 lines, -304 lines 0 comments Download
M ipc/ipc_message_macros.h View 6 chunks +85 lines, -196 lines 0 comments Download
M ipc/ipc_message_utils.h View 9 chunks +36 lines, -24 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D ipc/ipc_message_utils_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M printing/pdf_ps_metafile_cairo.h View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/pdf_ps_metafile_cairo.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pink (ping after 24hrs)
10 years, 4 months ago (2010-08-09 16:06:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698