Implement "Display Chrome OS in this language" button.

Implement "Display Chrome OS in this language" button.

Hopefully, the "Languages and Input" language dialog will be mostly
functional with this change, although we need to polish it more.

TEST=manually
BUG=chromium-os:4573
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55026

[satorux1, 2010-08-04 10:57:59]

Erik,

Thank you for your help, now the "Language and Input" page is mostly functional.

[arv (Not doing code reviews), 2010-08-04 17:39:13]

LGTM

http://codereview.chromium.org/3080026/diff/1/4
File chrome/browser/resources/options/chromeos_language_options.js (right):

http://codereview.chromium.org/3080026/diff/1/4#newcode143
chrome/browser/resources/options/chromeos_language_options.js:143:
uiLanguageButton.textContent = (
useless parentheses

http://codereview.chromium.org/3080026/diff/1/4#newcode147
chrome/browser/resources/options/chromeos_language_options.js:147:
uiLanguageButton.onclick = function(e) {}
noop

http://codereview.chromium.org/3080026/diff/1/4#newcode351
chrome/browser/resources/options/chromeos_language_options.js:351:
console.log(localStrings.getString('restart_required'));
I would at least do alert since that is user visible.

[satorux1, 2010-08-06 00:37:50]

The change has been checked in but forgot to send this...

http://codereview.chromium.org/3080026/diff/1/4
File chrome/browser/resources/options/chromeos_language_options.js (right):

http://codereview.chromium.org/3080026/diff/1/4#newcode143
chrome/browser/resources/options/chromeos_language_options.js:143:
uiLanguageButton.textContent = (
On 2010/08/04 17:39:13, arv wrote:
> useless parentheses

Done.

http://codereview.chromium.org/3080026/diff/1/4#newcode147
chrome/browser/resources/options/chromeos_language_options.js:147:
uiLanguageButton.onclick = function(e) {}
On 2010/08/04 17:39:13, arv wrote:
> noop

Done. Changed it to:

        // Remove the event listner.                                            
        uiLanguageButton.onclick = undefined;

Not sure if this is a preferable way. I'll change it if you have a better idea
in a separate patch.

http://codereview.chromium.org/3080026/diff/1/4#newcode351
chrome/browser/resources/options/chromeos_language_options.js:351:
console.log(localStrings.getString('restart_required'));
On 2010/08/04 17:39:13, arv wrote:
> I would at least do alert since that is user visible.

Done.