Issue 3080025: Get rid of FromWStringHack in chrome_mini_installer.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3080025: Get rid of FromWStringHack in chrome_mini_installer.cc. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Get rid of FromWStringHack in chrome_mini_installer.cc. This code is windows specific so it's ok to call FilePath(path) directly. BUG=24672 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55032

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -64 lines)			Patch
	M	chrome/test/mini_installer_test/chrome_mini_installer.h	View		6 chunks	+26 lines, -30 lines	0 comments	Download
	M	chrome/test/mini_installer_test/chrome_mini_installer.cc	View	1	8 chunks	+31 lines, -34 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/3080025/diff/2001/3001 File chrome/test/mini_installer_test/chrome_mini_installer.cc (right): http://codereview.chromium.org/3080025/diff/2001/3001#newcode438 chrome/test/mini_installer_test/chrome_mini_installer.cc:438: std::wstring username, append_path, shortcut_path; It seems these variables ...

10 years, 4 months ago (2010-08-04 17:48:58 UTC) #2

tfarina

http://codereview.chromium.org/3080025/diff/2001/3001 File chrome/test/mini_installer_test/chrome_mini_installer.cc (right): http://codereview.chromium.org/3080025/diff/2001/3001#newcode438 chrome/test/mini_installer_test/chrome_mini_installer.cc:438: std::wstring username, append_path, shortcut_path; On 2010/08/04 17:48:58, Evan Martin ...

10 years, 4 months ago (2010-08-04 23:56:05 UTC) #3

LGTM

Expand Messages | Collapse Messages