Issue 3080024: Add net/tools/spdyshark/ to the presubmit exclude path list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3080024: Add net/tools/spdyshark/ to the presubmit exclude path list. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Nico, Evan Martin

CC:
chromium-reviews

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Add net/tools/spdyshark/ to the presubmit exclude path list. With that the lint doesn't complain about bad license header. BUG=50266 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54857

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM with fix http://codereview.chromium.org/3080024/diff/1/2 File PRESUBMIT.py (right): http://codereview.chromium.org/3080024/diff/1/2#newcode15 PRESUBMIT.py:15: r"net/tools/spdyshark/[\\\/].*", Can you keep this alphabetized?

10 years, 4 months ago (2010-08-04 01:09:23 UTC) #2

tfarina

10 years, 4 months ago (2010-08-04 01:12:01 UTC) #4

http://codereview.chromium.org/3080024/diff/1/2
File PRESUBMIT.py (right):

http://codereview.chromium.org/3080024/diff/1/2#newcode15
PRESUBMIT.py:15: r"net/tools/spdyshark/[\\\/].*",
On 2010/08/04 01:09:23, Evan Martin wrote:
> Can you keep this alphabetized?

Done.

Expand Messages | Collapse Messages