Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 3080019: Add overlay_list script. (Closed)

Created:
10 years, 4 months ago by robotboy
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Add overlay_list script. This script generates the list of overlays, including variant overlays, for a particular board/variant combination. It will be called from setup_board.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Get rid of the find for private overlays. #

Patch Set 3 : Remove line breaks, warning message and fix 80 column wrapping. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A overlay_list View 1 2 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robotboy
I'm pulling out the overlay list generation code from setup_board because it's become large enough ...
10 years, 4 months ago (2010-08-02 21:01:03 UTC) #1
Antoine Labour
http://codereview.chromium.org/3080019/diff/1/2 File overlay_list (right): http://codereview.chromium.org/3080019/diff/1/2#newcode17 overlay_list:17: "The name of the board to set up." 4 ...
10 years, 4 months ago (2010-08-02 21:53:33 UTC) #2
robotboy
Comments addressed, PTAL. http://codereview.chromium.org/3080019/diff/1/2 File overlay_list (right): http://codereview.chromium.org/3080019/diff/1/2#newcode17 overlay_list:17: "The name of the board to ...
10 years, 4 months ago (2010-08-02 23:50:52 UTC) #3
Antoine Labour
10 years, 4 months ago (2010-08-02 23:58:37 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698