Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 3080015: Turn on prefetching in webkit builds (Closed)

Created:
10 years, 4 months ago by gavinp
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Turn on prefetching in webkit builds After http://codereview.chromium.org/2847093/show lands, I'll land this CL which modifies our build controls for webkit to turn on prefetching. This change might require builders to be clobbered, and by making it so small, I'm sure a sherriff will see what's up. However, I don't believe it will actually require a clobber, since there's no unit tests for prefetching (only functional tests and dumprendertree tests in webkit). TBR=tonyg@chromium.org BUG=none TEST=http://gemal.dk/browserspy/prefetching.php Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54509

Patch Set 1 : upload showing only diffs for this CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/features_override.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gavinp
10 years, 4 months ago (2010-07-31 11:39:37 UTC) #1
cbentzel
This CL also incorporates the prefetch-disabled-by-default logic from http://codereview.chromium.org/2847093/show This should just have the features_override.gypi ...
10 years, 4 months ago (2010-07-31 12:24:51 UTC) #2
gavinp
On 2010/07/31 12:24:51, cbentzel wrote: > This CL also incorporates the prefetch-disabled-by-default logic from > ...
10 years, 4 months ago (2010-07-31 12:28:15 UTC) #3
cbentzel
better way to do this with git is to create two branches. in this case, ...
10 years, 4 months ago (2010-07-31 12:33:26 UTC) #4
gavinp
10 years, 4 months ago (2010-07-31 12:36:03 UTC) #5
i ended up just expicitly specifying which branch to diff against, worked fine.

Powered by Google App Engine
This is Rietveld 408576698