Issue 3078028: Pay attention to TPM communication errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3078028: Pay attention to TPM communication errors (Closed)

Created:
10 years, 4 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Pay attention to TPM communication errors BUG=none TEST=make && make runtests

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify debugging #

Patch Set 3 : Fix whitespace #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -53 lines)			Patch
M	firmware/lib/tpm_lite/include/tlcl.h	View	1 2	3 chunks	+5 lines, -4 lines	0 comments	Download
M	firmware/lib/tpm_lite/include/tss_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	firmware/lib/tpm_lite/tlcl.c	View	1 2	10 chunks	+38 lines, -46 lines	0 comments	Download
M	firmware/stub/tpm_lite_stub.c	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	firmware/version.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 4 months ago (2010-08-05 22:45:42 UTC) #2

LGTM.  See minor comment.

http://codereview.chromium.org/3078028/diff/1/4
File firmware/lib/tpm_lite/tlcl.c (right):

http://codereview.chromium.org/3078028/diff/1/4#newcode68
firmware/lib/tpm_lite/tlcl.c:68: VBDEBUG(("TPM: command 0x%x send/receive
failed: 0x%x\n", command, result));
Why not
VBDEBUG((..., TpmCommandCode(request), result))
without the #ifdef

Expand Messages | Collapse Messages