Issue 3078026: New translate pyauto hook: select translate target language

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3078026: New translate pyauto hook: select translate target language (Closed)

Created:
10 years, 4 months ago by Alyssa

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

New translate pyauto hook: select translate target language This hook allows tests to select a different "to" language from the drop-down. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55000

Patch Set 1 : Initial #

Total comments: 2

Patch Set 2 : Final #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
	M	chrome/browser/automation/automation_provider.cc	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

10 years, 4 months ago (2010-08-04 21:36:24 UTC) #2

LGTM

http://codereview.chromium.org/3078026/diff/2001/3001
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/3078026/diff/2001/3001#newcode2843
chrome/browser/automation/automation_provider.cc:2843: for (int i = 0; i <
num_languages; i++) {
replace num_languages with translate_bar->GetLanguageCount() and get rid of last
line

http://codereview.chromium.org/3078026/diff/2001/3002
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/3078026/diff/2001/3002#newcode740
chrome/test/pyautolib/pyauto.py:740: Returns False if a new translation was
triggered and the translation
False, if a new translation....
True, on success

Expand Messages | Collapse Messages