Issue 3077003: Fully remove the hole in the Mac Sandbox that was used to support...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3077003: Fully remove the hole in the Mac Sandbox that was used to support... (Closed)

Created:
10 years, 5 months ago by Mark Schneckloth

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Amanda Walker, jeremy

CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fully remove the hole in the Mac Sandbox that was used to support Native Client. This removes the special sandbox commands as well as all special code. This CL replaces http://codereview.chromium.org/2881016/show which was rolled back because of problems on Mac OS X 10.5. Those problems were addressed in Native Client and pulled into Chrome with a DEPS file update in http://codereview.chromium.org/2881034/show which was committed as Chrome revision 53711. BUG=http://code.google.com/p/nativeclient/issues/detail?id=344 TEST=all tests pass, including nacl_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53936

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -59 lines)			Patch
M	chrome/browser/nacl_loader.sb	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/common/sandbox_init_wrapper_mac.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/common/sandbox_mac.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/sandbox_mac.mm	View	3 chunks	+0 lines, -23 lines	0 comments	Download
M	chrome/renderer/renderer.sb	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages