Add the firmware load test to the Network3G suite.

Add the firmware load test to the Network3G suite.

TEST=None

BUG=5103
Signed-Off-By: Elly Jones <ellyjones@chromium.org>;
Signed-Off-By: Eric Li <ericli@chromium.org>;

[ericli, 2010-08-06 16:07:22]

http://codereview.chromium.org/3076039/diff/1/2
File server/site_tests/suite_Network3G/control (right):

http://codereview.chromium.org/3076039/diff/1/2#newcode42
server/site_tests/suite_Network3G/control:42: def run_server_test(machine):
I would simply append 
for test in SERVER_TESTS:
  job.run_test(test, host=client)

to the end of run_client_test and rename it as run_tests or something similar.

and you dont need to call parallel_simple.

[Elly Fong-Jones, 2010-08-06 17:44:36]

On 2010/08/06 16:07:22, ericli wrote:
> http://codereview.chromium.org/3076039/diff/1/2
> File server/site_tests/suite_Network3G/control (right):
> 
> http://codereview.chromium.org/3076039/diff/1/2#newcode42
> server/site_tests/suite_Network3G/control:42: def run_server_test(machine):
> I would simply append 
> for test in SERVER_TESTS:
>   job.run_test(test, host=client)
> 
> to the end of run_client_test and rename it as run_tests or something similar.
> 
> and you dont need to call parallel_simple.

Don't the clients need to be run with parallel_on_machines(), whereas we want
all the 'server' tests to run locally with parallel_simple()?

[ericli, 2010-08-06 18:05:51]

You are right, I just recalled that too.
I take my comment back.

On 2010/08/06 17:44:36, Elly Jones wrote:
> On 2010/08/06 16:07:22, ericli wrote:
> > http://codereview.chromium.org/3076039/diff/1/2
> > File server/site_tests/suite_Network3G/control (right):
> > 
> > http://codereview.chromium.org/3076039/diff/1/2#newcode42
> > server/site_tests/suite_Network3G/control:42: def run_server_test(machine):
> > I would simply append 
> > for test in SERVER_TESTS:
> >   job.run_test(test, host=client)
> > 
> > to the end of run_client_test and rename it as run_tests or something
similar.
> > 
> > and you dont need to call parallel_simple.
> 
> Don't the clients need to be run with parallel_on_machines(), whereas we want
> all the 'server' tests to run locally with parallel_simple()?

[ericli, 2010-08-06 18:16:49]

LGTM.

On 2010/08/06 18:05:51, ericli wrote:
> You are right, I just recalled that too.
> I take my comment back.
> 
> On 2010/08/06 17:44:36, Elly Jones wrote:
> > On 2010/08/06 16:07:22, ericli wrote:
> > > http://codereview.chromium.org/3076039/diff/1/2
> > > File server/site_tests/suite_Network3G/control (right):
> > > 
> > > http://codereview.chromium.org/3076039/diff/1/2#newcode42
> > > server/site_tests/suite_Network3G/control:42: def
run_server_test(machine):
> > > I would simply append 
> > > for test in SERVER_TESTS:
> > >   job.run_test(test, host=client)
> > > 
> > > to the end of run_client_test and rename it as run_tests or something
> similar.
> > > 
> > > and you dont need to call parallel_simple.
> > 
> > Don't the clients need to be run with parallel_on_machines(), whereas we
want
> > all the 'server' tests to run locally with parallel_simple()?