cros_mark_all_as_stable: introduce blacklist, set the initial blacklist source as ./

cros_mark_all_as_stable: introduce blacklist, set the initial blacklist source as ./

* This allows to block a list of ebuilds from being uprevved by the PFB
* With little modification, there could be a GUI which allows people to manage
a blacklist on the server, with stating the reason
(ex.: autotest-tests - $me, creating the ebuild, unstable for now)

	modified:   cros_mark_all_as_stable

TEST=
1) create a blacklist:
chromeos-base/autotest
chromeos-base/autotest-tests
2) run ./cros_mark_all_as_stable --board=x86-generic
...
INFO   : chromeos-base/autotest blacklisted, skipping
INFO   : chromeos-base/autotest-tests blacklisted, skipping
...

[sosa, 2010-08-06 20:15:50]

Nits

http://codereview.chromium.org/3076038/diff/1/2
File cros_mark_all_as_stable (right):

http://codereview.chromium.org/3076038/diff/1/2#newcode43
cros_mark_all_as_stable:43: # file containing the names of blacklisted packages
File* and periods at end of comments.

http://codereview.chromium.org/3076038/diff/1/2#newcode44
cros_mark_all_as_stable:44: [ -f cros_mark_as_stable_blacklist ] && \
Can you check in a basic file for this

http://codereview.chromium.org/3076038/diff/1/2#newcode44
cros_mark_all_as_stable:44: [ -f cros_mark_as_stable_blacklist ] && \
Also check from dirname $0 (see below)

http://codereview.chromium.org/3076038/diff/1/2#newcode45
cros_mark_all_as_stable:45: PACKAGE_BLACKLIST=$(cat
cros_mark_as_stable_blacklist)
Use $(dirname "$0")/cros_mark_as_stable_blacklist

http://codereview.chromium.org/3076038/diff/1/2#newcode45
cros_mark_all_as_stable:45: PACKAGE_BLACKLIST=$(cat
cros_mark_as_stable_blacklist)
Define this variable before declaring it here with a comment explaining it.

[zbehan, 2010-08-06 20:21:34]

On Fri, Aug 6, 2010 at 1:15 PM, <sosa@chromium.org> wrote:

> Nits
>
>
> http://codereview.chromium.org/3076038/diff/1/2
> File cros_mark_all_as_stable (right):
>
> http://codereview.chromium.org/3076038/diff/1/2#newcode43
> cros_mark_all_as_stable:43: # file containing the names of blacklisted
> packages
> File* and periods at end of comments.
>
> http://codereview.chromium.org/3076038/diff/1/2#newcode44
> cros_mark_all_as_stable:44: [ -f cros_mark_as_stable_blacklist ] && \
> Can you check in a basic file for this
>

I can check in an empty file, yes. But I'd like to add my intended contents
for the blacklist in a separate CL.

http://codereview.chromium.org/3076038/diff/1/2#newcode44
> cros_mark_all_as_stable:44: [ -f cros_mark_as_stable_blacklist ] && \
> Also check from dirname $0 (see below)
>
> http://codereview.chromium.org/3076038/diff/1/2#newcode45
> cros_mark_all_as_stable:45: PACKAGE_BLACKLIST=$(cat
>
> cros_mark_as_stable_blacklist)
> Use $(dirname "$0")/cros_mark_as_stable_blacklist
>
> http://codereview.chromium.org/3076038/diff/1/2#newcode45
> cros_mark_all_as_stable:45: PACKAGE_BLACKLIST=$(cat
>
> cros_mark_as_stable_blacklist)
> Define this variable before declaring it here with a comment explaining
> it.
>
>
> http://codereview.chromium.org/3076038/show
>

Other comments - will fix.

[sosa, 2010-08-06 20:42:49]

Can you add a TEST= stanza to indicate how you tested it in your issue.  O/w
LGTM

http://codereview.chromium.org/3076038/diff/3002/6001
File cros_mark_all_as_stable (right):

http://codereview.chromium.org/3076038/diff/3002/6001#newcode42
cros_mark_all_as_stable:42: # List of IFS-delimited ebuilds to ignore
Period at end

[zbehan, 2010-08-06 20:55:25]

On Fri, Aug 6, 2010 at 1:42 PM, <sosa@chromium.org> wrote:

> Can you add a TEST= stanza to indicate how you tested it in your issue.
>  O/w
> LGTM
>

Heh, good call, when repeating my earlier test to describe TEST=, i realised
this in fact doesn't always work properly. I'll push a fix in a minute for
that and the rest.

[sosa, 2010-08-06 21:09:32]

LGTM with 80 char nits

http://codereview.chromium.org/3076038/diff/11001/6002
File cros_mark_all_as_stable (right):

http://codereview.chromium.org/3076038/diff/11001/6002#newcode52
cros_mark_all_as_stable:52: local blacklist_regex=$(for i in
${PACKAGE_BLACKLIST}; do echo -n "\\|${i}"; done)
Got some 80 char nits.

[sosa, 2010-08-06 21:15:58]

lgtm++