Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 3076033: Zero-out allocated buffer while creating kernel preamble header. (Closed)

Created:
10 years, 4 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Zero-out allocated buffer while creating kernel preamble header. Since the kernel vblocks are always padded out to a fixed size, the unused (padded) memory was ending up containing random bytes, leading to vbutil_kernel generating vblocks that are not bit-identical when run with the same inputs. BUG=none TEST=see below 1) Use vbutil_kernel with the same set of inputs to generate two alternative vblocks. 2) Compare the 2 files - they must be bitwise identical space. The padding bytes must all be set to 0. 3) Generate a new signed image using the resign_image.sh script under scripts/image_signing. This signed image should be boot and install successfully on a maching running our custom firmware using the same set of root, firmware, and kernel keys.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M firmware/version.c View 1 chunk +1 line, -1 line 0 comments Download
M host/lib/host_common.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 4 months ago (2010-08-04 23:38:04 UTC) #1
Bill Richardson
10 years, 4 months ago (2010-08-04 23:40:40 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698