Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 3076031: Add back the lost mock data to get rid of "undefined" in users options page. (Closed)

Created:
10 years, 4 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
dhg
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Add back the lost mock data to get rid of "undefined" in users options page. BUG=none TEST=Verify the mock user in users options page does not has "undefined" as their names. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/cros_settings_provider_user.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
10 years, 4 months ago (2010-08-04 22:00:33 UTC) #1
dhg
10 years, 4 months ago (2010-08-04 22:07:19 UTC) #2
LGTM

On Wed, Aug 4, 2010 at 3:00 PM,  <xiyuan@chromium.org> wrote:
> Reviewers: dhg,
>
> Description:
> Add back the lost mock data to get rid of "undefined" in users options page.
>
> BUG=none
> TEST=Verify the mock user in users options page does not has "undefined" as
> their names.
>
> Please review this at http://codereview.chromium.org/3076031/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/browser/chromeos/cros_settings_provider_user.cc
>
>
> Index: chrome/browser/chromeos/cros_settings_provider_user.cc
> diff --git a/chrome/browser/chromeos/cros_settings_provider_user.cc
> b/chrome/browser/chromeos/cros_settings_provider_user.cc
> index
>
3304648370a7d07b1299c0a0ebc9fd5be8470ece..8305e137844e2963417989b251894fd17e4f6e62
> 100644
> --- a/chrome/browser/chromeos/cros_settings_provider_user.cc
> +++ b/chrome/browser/chromeos/cros_settings_provider_user.cc
> @@ -13,15 +13,20 @@ UserCrosSettingsProvider::UserCrosSettingsProvider()
>     : dict_(new DictionaryValue) {
>   Set(kAccountsPrefAllowBWSI, Value::CreateBooleanValue(true));
>   Set(kAccountsPrefAllowGuest, Value::CreateBooleanValue(true));
> +  Set(kAccountsPrefShowUserNamesOnSignIn, Value::CreateBooleanValue(true));
>
>   ListValue* user_list = new ListValue;
>
>   DictionaryValue* mock_user = new DictionaryValue;
>   mock_user->SetString(L"email", L"mock_user_1@gmail.com");
> +  mock_user->SetString(L"name", L"Mock User One");
> +  mock_user->SetBoolean(L"owner", true);
>   user_list->Append(mock_user);
>
>   mock_user = new DictionaryValue;
>   mock_user->SetString(L"email", L"mock_user_2@gmail.com");
> +  mock_user->SetString(L"name", L"Mock User Two");
> +  mock_user->SetBoolean(L"owner", false);
>   user_list->Append(mock_user);
>
>   Set(kAccountsPrefUsers, user_list);
>
>
>

Powered by Google App Engine
This is Rietveld 408576698