Allow chrome for cros to be started with a username / password

To effectively test some parts of chrome for cros on the linux desktop, we need a way to start chrome logged in. The login UI requires the WM to display, so I added command line options to do this. But we needed the full functionality of login, which doesn't work when libcros can't be loaded. I created stubs for all the cros api. I then took both stubs and the real implementations and put them entirely inside the .cc files (no separate declaration of the implementations in the .h files).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54950

[Chris Masone, 2010-08-04 04:39:06]

http://codereview.chromium.org/3076029/diff/8001/9002
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9002#newcode719
chrome/browser/browser_main.cc:719: TestLogin* test_login = new TestLogin();
test_login is going to leak, isn't it?  Authenticator doesn't take ownership of
it.

http://codereview.chromium.org/3076029/diff/8001/9002#newcode748
chrome/browser/browser_main.cc:748: DISABLE_RUNNABLE_METHOD_REFCOUNT(TestLogin);
What's this for?

http://codereview.chromium.org/3076029/diff/8001/9003
File chrome/browser/chromeos/cros/cros_library.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9003#newcode24
chrome/browser/chromeos/cros/cros_library.cc:24: template <class L>
A comment to explain this?

http://codereview.chromium.org/3076029/diff/8001/9007
File chrome/browser/chromeos/cros/input_method_library.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9007#newcode62
chrome/browser/chromeos/cros/input_method_library.cc:62:
scoped_ptr<InputMethodDescriptors> input_method_descriptors(
indenting

[DaveMoore, 2010-08-04 17:04:06]

http://codereview.chromium.org/3076029/diff/8001/9002
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9002#newcode719
chrome/browser/browser_main.cc:719: TestLogin* test_login = new TestLogin();
It would have leaked. I've reworked it to not.
On 2010/08/04 04:39:06, Chris Masone wrote:
> test_login is going to leak, isn't it?  Authenticator doesn't take ownership
of
> it.

http://codereview.chromium.org/3076029/diff/8001/9002#newcode748
chrome/browser/browser_main.cc:748: DISABLE_RUNNABLE_METHOD_REFCOUNT(TestLogin);
It's to allow instances of TestLogin (now StubLogin) to be used even though they
don't support refcounting. I've added a comment.
On 2010/08/04 04:39:06, Chris Masone wrote:
> What's this for?

http://codereview.chromium.org/3076029/diff/8001/9003
File chrome/browser/chromeos/cros/cros_library.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9003#newcode24
chrome/browser/chromeos/cros/cros_library.cc:24: template <class L>
On 2010/08/04 04:39:06, Chris Masone wrote:
> A comment to explain this?

Done.

http://codereview.chromium.org/3076029/diff/8001/9007
File chrome/browser/chromeos/cros/input_method_library.cc (right):

http://codereview.chromium.org/3076029/diff/8001/9007#newcode62
chrome/browser/chromeos/cros/input_method_library.cc:62:
scoped_ptr<InputMethodDescriptors> input_method_descriptors(
On 2010/08/04 04:39:06, Chris Masone wrote:
> indenting

Done.

[Chris Masone, 2010-08-04 17:13:30]

LGTM

I dig it