Fix WebSocket crash bug.

Fix WebSocket crash bug.

If SocketStream closes while waiting ResolveProxy, it badly
calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close,
and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted.

So, don't run DoLoop when closed, if SocketStream is calling APIs of
proxy_service or resolver. Check closing_ after the API calls back
and closes the SocketStream.

r54707 broke SocketStreamTest::CloseFlushPendingWrite.
This CL fixes this by not closing socket if it is still writing on the socket.

BUG=50394, 46750
TEST=websocket/tests doesn't crash, and net_unittests passes

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55043

[tyoshino (SeeGerritForStatus), 2010-08-04 06:20:36]

http://codereview.chromium.org/3076024/diff/3001/4001
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/3076024/diff/3001/4001#newcode887
net/socket_stream/socket_stream.cc:887: DCHECK(read_buf_);
we've added "&& server_closed_" above. Does this still hold?

http://codereview.chromium.org/3076024/diff/3001/4003
File net/socket_stream/socket_stream_unittest.cc (right):

http://codereview.chromium.org/3076024/diff/3001/4003#newcode310
net/socket_stream/socket_stream_unittest.cc:310: // Server doesn't close the
connection after handshake.
say...
SocketStream::DoClose is run asynchronously. Socket can be read after \r\n. We
have to give ERR_IO_PENDING to SocketStream then.

[ukai, 2010-08-04 07:31:00]

http://codereview.chromium.org/3076024/diff/3001/4001
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/3076024/diff/3001/4001#newcode887
net/socket_stream/socket_stream.cc:887: DCHECK(read_buf_);
On 2010/08/04 06:20:36, tyoshino wrote:
> we've added "&& server_closed_" above. Does this still hold?

Done.

http://codereview.chromium.org/3076024/diff/3001/4003
File net/socket_stream/socket_stream_unittest.cc (right):

http://codereview.chromium.org/3076024/diff/3001/4003#newcode310
net/socket_stream/socket_stream_unittest.cc:310: // Server doesn't close the
connection after handshake.
On 2010/08/04 06:20:36, tyoshino wrote:
> say...
> SocketStream::DoClose is run asynchronously. Socket can be read after \r\n. We
> have to give ERR_IO_PENDING to SocketStream then.

Done.

[tyoshino (SeeGerritForStatus), 2010-08-05 08:31:54]

LGTM