Issue 3076020: Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3076020: Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API. This reverts commit 7ed083f6d2b1b0a09c8bf9470386ba3e38f2feed. It was reverted due to crbug.com/50663 started failing when I land this patch, so I'm relanding it now again. BUG=None TEST=trybots TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3043018 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54451

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -40 lines)			Patch
M	app/l10n_util_unittest.cc	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	base/env_var.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	base/env_var.cc	View	3 chunks	+19 lines, -4 lines	0 comments	Download
M	base/env_var_unittest.cc	View	2 chunks	+20 lines, -1 line	0 comments	Download
M	base/xdg_util_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/locale_tests_uitest.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/shell_integration_unittest.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/zygote_host_linux.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/plugin/plugin_main_mac.mm	View	2 chunks	+16 lines, -12 lines	1 comment	Download
M	net/proxy/proxy_config_service_linux_unittest.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 4 months ago (2010-08-01 18:22:51 UTC) #2

LGTM with nit below:

http://codereview.chromium.org/3076020/diff/1/10
File chrome/plugin/plugin_main_mac.mm (right):

http://codereview.chromium.org/3076020/diff/1/10#newcode28
chrome/plugin/plugin_main_mac.mm:28: int suffix_offset =
strlen(interpose_list.c_str()) -
You forgot to fix this per vtl's comments from the previous review.

Expand Messages | Collapse Messages