Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found it...

Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found it
weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in
string_util.h. This should help some dependencies since string_util changes
much more frequently than utf_string_conversions and fewer files will now need
string_utils.

Since this requires a lot of changes, this keeps a forward-declaration in
string_util so I can update the entire project incrementally. This change
updates base and net only.

I removed some includes of string_util from header files in net. In particular,
url_request_context which involved creating a new .cc file to implement a
function (already virtual so there's no speed penalty). It turns out a lot of
files were getting string_util from this include, so I had to update a bunch of
random files to now explicitly include string_util.h

TEST=it compiles
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54456

[Peter Kasting, 2010-07-28 22:19:32]

http://codereview.chromium.org/3076013/diff/24001/25001
File base/command_line.cc (right):

http://codereview.chromium.org/3076013/diff/24001/25001#newcode24
base/command_line.cc:24: //#include "base/string_piece.h"
Nit: This line should either be in or out.

http://codereview.chromium.org/3076013/diff/24001/25004
File base/string_util.h (right):

http://codereview.chromium.org/3076013/diff/24001/25004#newcode235
base/string_util.h:235: // Forward-declares for funcitons in
utf_string_conversions.h. They used to
Nit: funcitons -> functions

http://codereview.chromium.org/3076013/diff/24001/25005
File base/utf_string_conversions.cc (right):

http://codereview.chromium.org/3076013/diff/24001/25005#newcode1
base/utf_string_conversions.cc:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
Nit: 2010

http://codereview.chromium.org/3076013/diff/24001/25006
File base/utf_string_conversions.h (right):

http://codereview.chromium.org/3076013/diff/24001/25006#newcode1
base/utf_string_conversions.h:1: // Copyright (c) 2009 The Chromium Authors. All
rights reserved.
Nit: 2010

http://codereview.chromium.org/3076013/diff/24001/25006#newcode54
base/utf_string_conversions.h:54: // Note that this doesn't use StringPiece
because this is one of the most
This comment is a little confusing, because I assume what you'd do if you had
StringPiece is to use it as the function argument.  But you can do that via the
forward-declare this file already has (see UTF8ToWide() above).  Or am I
confused?

http://codereview.chromium.org/3076013/diff/24001/25012
File chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
(right):

http://codereview.chromium.org/3076013/diff/24001/25012#newcode1
chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc:1: //
Copyright (c) 2009 The Chromium Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3076013/diff/24001/25014
File net/base/cookie_store.h (right):

http://codereview.chromium.org/3076013/diff/24001/25014#newcode1
net/base/cookie_store.h:1: // Copyright (c) 2006-2009 The Chromium Authors. All
rights reserved.
Nit: 2010

http://codereview.chromium.org/3076013/diff/24001/25023
File net/net.gyp (right):

http://codereview.chromium.org/3076013/diff/24001/25023#newcode533
net/net.gyp:533: 'url_request/url_request_context.cc',
You didn't actually svn add this file to the changelist.

[brettw, 2010-07-28 22:44:15]

All addressed, new snap up.

[Peter Kasting, 2010-07-28 22:49:34]

You still didn't svn add url_request_context.cc.  Without this the change won't
compile.

LGTM otherwise.

http://codereview.chromium.org/3076013/diff/15004/33008
File base/utf_string_conversions.h (right):

http://codereview.chromium.org/3076013/diff/15004/33008#newcode1
base/utf_string_conversions.h:1: // Copyright (c) 2009 The Chromium Authors. All
rights reserved.
Nit: 2010