Issue 3076009: Make oem_customization flag optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3076009: Make oem_customization flag optional. (Closed)

Created:
10 years, 5 months ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Make oem_customization flag optional. BUG=chromium-os:1888 TEST=Manual. build_image should run fine when oem_customization flag is not specified.

Patch Set 1 #

Patch Set 2 : fix script #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	build_image	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

anush

10 years, 4 months ago (2010-07-28 14:47:18 UTC) #3

LGTM thanks.

On Wed, Jul 28, 2010 at 3:49 AM, <nkostylev@chromium.org> wrote:

> Reviewers: Dmitry Polukhin,
>
> Description:
> Make oem_customization flag optional.
>
> BUG=chromium-os:1888
> TEST=Manual. build_image should run fine when oem_customization flag is not
> specified.
>
> Please review this at http://codereview.chromium.org/3076009/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
>
> Affected files:
>  M build_image
>
>
> Index: build_image
> diff --git a/build_image b/build_image
> index
>
d97f75c88596639ab6722bc1d3e26b791881cd65..386156cc4e181d72fa4bf16b85a8e172a2182e8e
> 100755
> --- a/build_image
> +++ b/build_image
> @@ -77,8 +77,7 @@ DEFINE_integer verity_max_ios 1024 \
>  DEFINE_string verity_algorithm "sha1" \
>   "Cryptographic hash algorithm used for kernel vboot. Default : sha1"
>
> -DEFINE_string oem_customization \
> -  "$GCLIENT_ROOT/src/platform/assets/oem_customization" \
> +DEFINE_string oem_customization "" \
>   "Path to directory containing OEM partner partition contents"
>
>  # Parse command line.
>
>
>

Expand Messages | Collapse Messages