Issue 3075001: Remove DARK_TRANSPARENT omnibox images. The comments for why we need them ar...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3075001: Remove DARK_TRANSPARENT omnibox images. The comments for why we need them ar... (Closed)

Created:
10 years, 5 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove IDR_OMNIBOX_*_TRANSPARENT images. The comments for why we need them are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set. BUG=50107 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53733

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -29 lines)			Patch
	M	chrome/app/theme/theme_resources.grd	View		1 chunk	+0 lines, -8 lines	0 comments	Download
	M	chrome/browser/gtk/gtk_theme_provider.cc	View		1 chunk	+6 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

+erg don't you want to delete the actual images from the tree as well

10 years, 5 months ago (2010-07-26 21:27:30 UTC) #2

Elliot Glaysher

LGTM. Should probably work, but you'll want to verify this on a linux build, in ...

10 years, 5 months ago (2010-07-26 21:30:37 UTC) #3

Peter Kasting

10 years, 5 months ago (2010-07-26 21:30:40 UTC) #4

Yes, that's included on my local side; trybots don't like binary changes.

Thanks for checking on it, though, I might have forgotten to stick it in my
local patch.

Expand Messages | Collapse Messages