Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 3074021: Prettify blocked plugin HTML UI (Closed)

Created:
10 years, 4 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Prettify blocked plugin HTML UI: * Make run plugin link look more like a link (blue and underlined on hover). * Change wording to "Run plug-in this time" ("load plug-in" might get confused with installing a plug-in) * Add a small explanatory message BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55060

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/blocked_plugin.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/blocked_plugin.html View 2 chunks +17 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Would you like to review this or should I send it to someone else?
10 years, 4 months ago (2010-08-02 14:25:57 UTC) #1
Pam (message me for reviews)
Sorry about the delay; this fell off my email list. LGTM, with one query below. ...
10 years, 4 months ago (2010-08-04 18:22:43 UTC) #2
Bernhard Bauer
On Wed, Aug 4, 2010 at 20:22, <pam@chromium.org> wrote: > Sorry about the delay; this ...
10 years, 4 months ago (2010-08-05 10:00:39 UTC) #3
Pam (message me for reviews)
10 years, 4 months ago (2010-08-05 10:08:02 UTC) #4
> > Do we have any mechanism for allowing users to override these sorts of
> > things? Blue on pale yellow ought to be OK for most people, even those
> > who are color-blind if I understand correctly, but there are always some
> > who want high-contrast or other special color schemes.
> 
> Hum. At the moment we don't, and I wouldn't exactly know where to put
> such a mechanism :-/

Filed http://crbug.com/51260. Still LGTM.

- Pam

Powered by Google App Engine
This is Rietveld 408576698