Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 3074010: Revert 53989 - Implement new mock for user options page per chromium-os:5028... (Closed)

Created:
10 years, 4 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 53989 - Implement new mock for user options page per chromium-os:5028 BUG=chromium-os:5028 TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only. Review URL: http://codereview.chromium.org/2868067 TBR=xiyuan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -336 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/cros_settings_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros_settings_names.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/accounts_options_handler.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/mock_cros_settings.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/options_ui.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/chromeos_accounts_options.html View 2 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/resources/options/chromeos_accounts_options.js View 1 chunk +12 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/chromeos_accounts_options_page.css View 1 chunk +3 lines, -65 lines 0 comments Download
M chrome/browser/resources/options/chromeos_accounts_user_list.js View 3 chunks +24 lines, -81 lines 0 comments Download
D chrome/browser/resources/options/chromeos_accounts_user_name_edit.js View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
10 years, 4 months ago (2010-07-29 13:52:28 UTC) #1
Alexander Potapenko
10 years, 4 months ago (2010-07-29 15:30:14 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698