Issue 3074007: Avoid js exception in history.pushState by not changing url per csilv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3074007: Avoid js exception in history.pushState by not changing url per csilv (Closed)

Created:
10 years, 4 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org, zel

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Avoid js exception in history.pushState by not changing url. Also added a missing OptionsPage.setState call. BUG=none TEST=OptionsPage should work as expected when switching tabs and users/network list should be populated properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54017

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/options_page.js	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

10 years, 4 months ago (2010-07-28 20:44:55 UTC) #3

LGTM

Tested and works well.  While pages don't show up in browser history, the
forward/backward buttons work fine which is nice.

Expand Messages | Collapse Messages