Issue 3073026: Expose the type of an AccessibilityControlInfo. (This will allow us...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3073026: Expose the type of an AccessibilityControlInfo. (This will allow us... (Closed)

Created:
10 years, 4 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, ben+cc_chromium.org, Chaitanya

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Expose the type of an AccessibilityControlInfo. (This will allow us to use this same accessibility event code to make the Chrome OS login screen speak, before accessibility extensions are loaded.) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55178

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -23 lines)			Patch
	M	chrome/browser/accessibility_events.h	View		12 chunks	+22 lines, -4 lines	0 comments	Download
	M	chrome/browser/accessibility_events.cc	View		1 chunk	+37 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

10 years, 4 months ago (2010-08-05 16:03:10 UTC) #2

LGTM

I don't know this code or what depends on it, so I'm just reviewing the
correctness of the change in isolation.

Expand Messages | Collapse Messages