Issue 3073018: Merge 53841 - Cleanup: Remove pointless GetInsets() override. Simplify |cont...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3073018: Merge 53841 - Cleanup: Remove pointless GetInsets() override. Simplify |cont... (Closed)

Created:
10 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 53841 - Cleanup: Remove pointless GetInsets() override. Simplify |container_size_| to just be |container_width_|. Fix indenting/alignment, especially of function parameters. L"" -> std::wstring(). Don't handle assertion violations (style guide/simplicity). Reduce indenting via early-return or simpler-path-return. Streamline code where possible. Definition order should match declaration order. EXPECT_STREQ -> EXPECT_EQ. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3076001 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54668

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+307 lines, -367 lines)			Patch
M	chrome/browser/views/browser_actions_container.h	View	4 chunks	+14 lines, -18 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	28 chunks	+284 lines, -340 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container_browsertest.cc	View	4 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages