Autotest for ScreenLocker

Autotest for ScreenLocker
 * Removed old ScreenSaverUnlock and utility methods
 * Added new ScreenLocker test
 * updated site_ui_tests.py so that it can process dbus signal.
 * Changed poll_for_condition to use TimeoutError (assuming that's the intention)

BUG=chromium-os:2918
TEST=new desktopui_ScreenLocker test should pass

[oshima, 2010-08-16 19:47:30]

friendly ping

On 2010/07/31 05:47:10, oshima wrote:
>

[sosa, 2010-08-16 21:50:49]

Sorry about getting back so late on this.  Can you also add this to the BVT
suite?

http://codereview.chromium.org/3073014/diff/2001/3001
File client/bin/site_login.py (left):

http://codereview.chromium.org/3073014/diff/2001/3001#oldcode197
client/bin/site_login.py:197: def
wait_for_screensaver(timeout=_DEFAULT_TIMEOUT):
Are you sure there are no callers to this function?

http://codereview.chromium.org/3073014/diff/2001/3002
File client/bin/site_ui_test.py (left):

http://codereview.chromium.org/3073014/diff/2001/3002#oldcode62
client/bin/site_ui_test.py:62: """Returns True if the screensaver is locked,
false otherwise.
Are you sure there are no callers to these functions?

http://codereview.chromium.org/3073014/diff/2001/3002
File client/bin/site_ui_test.py (right):

http://codereview.chromium.org/3073014/diff/2001/3002#newcode54
client/bin/site_ui_test.py:54: """ Listens to the given |signal| that is sent to
power manager. """
No spaces between docstring and quotes

http://codereview.chromium.org/3073014/diff/2001/3005
File client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py (right):

http://codereview.chromium.org/3073014/diff/2001/3005#newcode5
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:5: import
time
alphabetize

http://codereview.chromium.org/3073014/diff/2001/3005#newcode25
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:25: """
Process dbug events """
No spaces between docstring and quotes

http://codereview.chromium.org/3073014/diff/2001/3005#newcode25
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:25: """
Process dbug events """
s/dbug/dbus

http://codereview.chromium.org/3073014/diff/2001/3005#newcode47
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:47: # the
accelerator.
Any particular reason for 2 sec?  Maybe increase to 5 to be extra sure so we
don't have a flaky test

[oshima, 2010-08-17 22:36:59]

http://codereview.chromium.org/3073014/diff/2001/3002
File client/bin/site_ui_test.py (left):

http://codereview.chromium.org/3073014/diff/2001/3002#oldcode62
client/bin/site_ui_test.py:62: """Returns True if the screensaver is locked,
false otherwise.
On 2010/08/16 21:50:49, sosa wrote:
> Are you sure there are no callers to these functions?

I grep'ed all python under autotest/files. Are there other places I should look
at?
I'll run Nightly and BVT just in case.

http://codereview.chromium.org/3073014/diff/2001/3002
File client/bin/site_ui_test.py (right):

http://codereview.chromium.org/3073014/diff/2001/3002#newcode54
client/bin/site_ui_test.py:54: """ Listens to the given |signal| that is sent to
power manager. """
On 2010/08/16 21:50:49, sosa wrote:
> No spaces between docstring and quotes

Done.

http://codereview.chromium.org/3073014/diff/2001/3005
File client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py (right):

http://codereview.chromium.org/3073014/diff/2001/3005#newcode5
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:5: import
time
On 2010/08/16 21:50:49, sosa wrote:
> alphabetize

Done.

http://codereview.chromium.org/3073014/diff/2001/3005#newcode25
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:25: """
Process dbug events """
On 2010/08/16 21:50:49, sosa wrote:
> s/dbug/dbus

Done.

http://codereview.chromium.org/3073014/diff/2001/3005#newcode47
client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:47: # the
accelerator.
On 2010/08/16 21:50:49, sosa wrote:
> Any particular reason for 2 sec?  Maybe increase to 5 to be extra sure so we
> don't have a flaky test

I just took from old test that waits for xscreensaver to wake up and seems to be
working fine on my device, but increased to 5 seconds just incase.

[oshima, 2010-08-18 00:46:36]

I verified that suite_BuildVerify passes with this change



On 2010/08/17 22:36:59, oshima wrote:
> http://codereview.chromium.org/3073014/diff/2001/3002
> File client/bin/site_ui_test.py (left):
> 
> http://codereview.chromium.org/3073014/diff/2001/3002#oldcode62
> client/bin/site_ui_test.py:62: """Returns True if the screensaver is locked,
> false otherwise.
> On 2010/08/16 21:50:49, sosa wrote:
> > Are you sure there are no callers to these functions?
> 
> I grep'ed all python under autotest/files. Are there other places I should
look
> at?
> I'll run Nightly and BVT just in case.
> 
> http://codereview.chromium.org/3073014/diff/2001/3002
> File client/bin/site_ui_test.py (right):
> 
> http://codereview.chromium.org/3073014/diff/2001/3002#newcode54
> client/bin/site_ui_test.py:54: """ Listens to the given |signal| that is sent
to
> power manager. """
> On 2010/08/16 21:50:49, sosa wrote:
> > No spaces between docstring and quotes
> 
> Done.
> 
> http://codereview.chromium.org/3073014/diff/2001/3005
> File client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py
(right):
> 
> http://codereview.chromium.org/3073014/diff/2001/3005#newcode5
> client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:5: import
> time
> On 2010/08/16 21:50:49, sosa wrote:
> > alphabetize
> 
> Done.
> 
> http://codereview.chromium.org/3073014/diff/2001/3005#newcode25
> client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:25: """
> Process dbug events """
> On 2010/08/16 21:50:49, sosa wrote:
> > s/dbug/dbus
> 
> Done.
> 
> http://codereview.chromium.org/3073014/diff/2001/3005#newcode47
> client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py:47: # the
> accelerator.
> On 2010/08/16 21:50:49, sosa wrote:
> > Any particular reason for 2 sec?  Maybe increase to 5 to be extra sure so we
> > don't have a flaky test
> 
> I just took from old test that waits for xscreensaver to wake up and seems to
be
> working fine on my device, but increased to 5 seconds just incase.

[oshima, 2010-08-18 01:10:55]

Eric,

I'd like to add this to Nightly and BVT. Could you please review this too?

[ericli, 2010-08-18 03:10:00]

you dont need to add it to both test suite, either one is fine, and I would
leave that to you.

Note if this test demonstrates flakiness if add to BVT, I might move it back to
Nightly later.

[ericli, 2010-08-18 03:10:45]

And I didn't see where is the unlock case in any test suites?

On 2010/08/18 03:10:00, ericli wrote:
> you dont need to add it to both test suite, either one is fine, and I would
> leave that to you.
> 
> Note if this test demonstrates flakiness if add to BVT, I might move it back
to
> Nightly later.

[sosa, 2010-08-18 07:38:55]

Yes I'd like to see this in the bvt's.  Please remove from nightly given eric's
feedback but o/w LGTM

[oshima, 2010-08-18 18:39:51]

On 2010/08/18 03:10:45, ericli wrote:
> And I didn't see where is the unlock case in any test suites?

The desktopui_ScreenLocker tests both unlock failure and
successful unlock cases.

- oshima
 
> On 2010/08/18 03:10:00, ericli wrote:
> > you dont need to add it to both test suite, either one is fine, and I would
> > leave that to you.
> > 
> > Note if this test demonstrates flakiness if add to BVT, I might move it back
> to
> > Nightly later.

[oshima, 2010-08-18 18:40:29]

On 2010/08/18 07:38:55, sosa wrote:
> Yes I'd like to see this in the bvt's.  Please remove from nightly given
eric's
> feedback but o/w LGTM

removed from nightly and checking in...

[ericli, 2010-08-18 18:43:22]

Got it,
Just found there is a D in front of the unlock python file.

LGTM.

On 2010/08/18 18:40:29, oshima wrote:
> On 2010/08/18 07:38:55, sosa wrote:
> > Yes I'd like to see this in the bvt's.  Please remove from nightly given
> eric's
> > feedback but o/w LGTM
> 
> removed from nightly and checking in...

[oshima, 2010-08-20 22:19:20]

Eric, how I can add a column for screen locker test in "
http://chromiumos-test-dash.appspot.com/"?
It doesn't have it right now and I can't tell if it's working.

thanks,
- oshima

On Wed, Aug 18, 2010 at 11:43 AM, <ericli@chromium.org> wrote:

> Got it,
> Just found there is a D in front of the unlock python file.
>
> LGTM.
>
>
> On 2010/08/18 18:40:29, oshima wrote:
>
>> On 2010/08/18 07:38:55, sosa wrote:
>> > Yes I'd like to see this in the bvt's.  Please remove from nightly given
>> eric's
>> > feedback but o/w LGTM
>>
>
>  removed from nightly and checking in...
>>
>
>
>
> http://codereview.chromium.org/3073014/show
>

[ericli, 2010-08-20 22:29:10]

You dont look at that url.

Look at this in the future:
http://cautotest/results/dashboard/netbook_DELL_L13/

But it does not have it either. They reason is the buildbot didn't pick up
the latest autotest change yet. Not only your screenlock test, there are
couple of more I identified this morning.

I dont why buildbot did not pick up the latest changes...

Eric.

On Fri, Aug 20, 2010 at 3:18 PM, oshima <oshima@chromium.org> wrote:

> Eric, how I can add a column for screen locker test in "
> http://chromiumos-test-dash.appspot.com/"?
> It doesn't have it right now and I can't tell if it's working.
>
> thanks,
> - oshima
>
> On Wed, Aug 18, 2010 at 11:43 AM, <ericli@chromium.org> wrote:
>
>> Got it,
>> Just found there is a D in front of the unlock python file.
>>
>> LGTM.
>>
>>
>> On 2010/08/18 18:40:29, oshima wrote:
>>
>>> On 2010/08/18 07:38:55, sosa wrote:
>>> > Yes I'd like to see this in the bvt's.  Please remove from nightly
>>> given
>>> eric's
>>> > feedback but o/w LGTM
>>>
>>
>>  removed from nightly and checking in...
>>>
>>
>>
>>
>> http://codereview.chromium.org/3073014/show
>>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[sosa, 2010-08-20 22:32:35]

Autotest is still blacklisted from being auto-revved in the new
workflow.  Since the buildbots have switched to the new workflow, they
are only building stable packages (so autotest isn't getting rebuilt).

On Fri, Aug 20, 2010 at 3:29 PM, Eric Li(李咏竹) <ericli@chromium.org> wrote:
> You dont look at that url.
> Look at this in the future:
> http://cautotest/results/dashboard/netbook_DELL_L13/
> But it does not have it either. They reason is the buildbot didn't pick up
> the latest autotest change yet. Not only your screenlock test, there are
> couple of more I identified this morning.
> I dont why buildbot did not pick up the latest changes...
> Eric.
> On Fri, Aug 20, 2010 at 3:18 PM, oshima <oshima@chromium.org> wrote:
>>
>> Eric, how I can add a column for screen locker test in
>> "http://chromiumos-test-dash.appspot.com/"?
>> It doesn't have it right now and I can't tell if it's working.
>> thanks,
>> - oshima
>> On Wed, Aug 18, 2010 at 11:43 AM, <ericli@chromium.org> wrote:
>>>
>>> Got it,
>>> Just found there is a D in front of the unlock python file.
>>>
>>> LGTM.
>>>
>>> On 2010/08/18 18:40:29, oshima wrote:
>>>>
>>>> On 2010/08/18 07:38:55, sosa wrote:
>>>> > Yes I'd like to see this in the bvt's.  Please remove from nightly
>>>> > given
>>>> eric's
>>>> > feedback but o/w LGTM
>>>
>>>> removed from nightly and checking in...
>>>
>>>
>>>
>>> http://codereview.chromium.org/3073014/show
>>
>
>
>
> --
> Eric Li
> 李咏竹
> Google Kirkland
>
>
>