BrowserMain() refactoring, part 2.1.

chrome/browser/browser_main.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSER_MAIN_H_
 #define CHROME_BROWSER_BROWSER_MAIN_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/field_trial.h"
@@ skipping 30 matching lines @@
 //
 // Parts:
 //  - EarlyInitialization: things which should be done as soon as possible on
 //    program start (such as setting up signal handlers) and things to be done
 //    at some generic time before the start of the main message loop.
 //  - MainMessageLoopStart: things beginning with the start of the main message
 //    loop and ending with initialization of the main thread; platform-specific
 //    things which should be done immediately before the start of the main
 //    message loop should go in |PreMainMessageLoopStart()|.
 //  - (more to come)
+//
+// How to add stuff (to existing parts):
+//  - Figure out when your new code should be executed. What must happen
+//    before/after your code is executed? Are there performance reasons for
+//    running your code at a particular time? Document these things!
+//  - Split out any platform-specific bits. Please avoid #ifdefs it at all
+//    possible. You have two choices for platform-specific code: (1) Execute it
+//    from one of the platform-specific |Pre/Post...()| methods; do this if the
+//    code is unique to a platform type. Or (2) execute it from one of the
+//    "parts" (e.g., |EarlyInitialization()|) and provide platform-specific
+//    implementations of your code (in a virtual method); do this if you need to
+//    provide different implementations across most/all platforms.
+//  - Unless your new code is just one or two lines, put it into a separate
+//    method with a well-defined purpose. (Likewise, if you're adding to an
+//    existing chunk which makes it longer than one or two lines, please move
+//    the code out into a separate method.)
 class BrowserMainParts {
  public:
   // This static method is to be implemented by each platform and should
   // instantiate the appropriate subclass.
   static BrowserMainParts* CreateBrowserMainParts(
       const MainFunctionParams& parameters);
 
   virtual ~BrowserMainParts();
 
   // Parts to be called by |BrowserMain()|.
@@ skipping 27 matching lines @@
   // A/B test for the maximum number of persistent connections per host.
   void ConnectionFieldTrial();
 
   // A/B test for determining a value for unused socket timeout.
   void SocketTimeoutFieldTrial();
 
   // A/B test for spdy when --use-spdy not set.
   void SpdyFieldTrial();
 
   // Used to initialize NSPR where appropriate.
-  void InitializeSSL();
+  virtual void InitializeSSL() = 0;
 
   // Methods for |MainMessageLoopStart()| --------------------------------------
 
   void InitializeMainThread();
 
   // Members initialized on construction ---------------------------------------
 
   const MainFunctionParams& parameters_;
   const CommandLine& parsed_command_line_;
 
@@ skipping 26 matching lines @@
 // sending crash reports.  The presence of a Breakpad handler (after
 // attempting to initialize crash reporting) and the presence of a debugger
 // are registered with the UMA metrics service.
 void RecordBreakpadStatusUMA(MetricsService* metrics);
 
 // Displays a warning message if some minimum level of OS support is not
 // present on the current platform.
 void WarnAboutMinimumSystemRequirements();
 
 #endif  // CHROME_BROWSER_BROWSER_MAIN_H_