Issue 3072028: Build the language list just like we do in the C++ version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3072028: Build the language list just like we do in the C++ version. (Closed)

Created:
10 years, 4 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Build the language list just like we do in the C++ version. Build the language list from supported input methods, as well as kExtraLanguages which don't have associated input methods. TEST=manually BUG=chromium-os:4573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55195

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : address comments #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -18 lines)			Patch
	M	chrome/browser/chromeos/dom_ui/language_options_handler.h	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/dom_ui/language_options_handler.cc	View	1	4 chunks	+31 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

lgtm http://codereview.chromium.org/3072028/diff/2001/3002 File chrome/browser/chromeos/dom_ui/language_options_handler.h (right): http://codereview.chromium.org/3072028/diff/2001/3002#newcode31 chrome/browser/chromeos/dom_ui/language_options_handler.h:31: // [{'id': 'pinyin', 'displayName': 'Pinyin', 'languageCode': 'zh-CW'}, ...] ...

10 years, 4 months ago (2010-08-06 05:53:35 UTC) #2

satorux1

10 years, 4 months ago (2010-08-06 06:10:35 UTC) #3

http://codereview.chromium.org/3072028/diff/2001/3002
File chrome/browser/chromeos/dom_ui/language_options_handler.h (right):

http://codereview.chromium.org/3072028/diff/2001/3002#newcode31
chrome/browser/chromeos/dom_ui/language_options_handler.h:31: // [{'id':
'pinyin', 'displayName': 'Pinyin', 'languageCode': 'zh-CW'}, ...]
On 2010/08/06 05:53:36, Yusuke Sato wrote:
> please write a short comment what |descriptors| is for.

Done.

http://codereview.chromium.org/3072028/diff/2001/3002#newcode37
chrome/browser/chromeos/dom_ui/language_options_handler.h:37: ListValue*
GetLanguageList(const InputMethodDescriptors& descriptors);
On 2010/08/06 05:53:36, Yusuke Sato wrote:
> ditto

Done.

Expand Messages | Collapse Messages