Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 3072025: Modify the SPDY v1 hack to only advertise v1 and not v2 over NPN.... (Closed)

Created:
10 years, 4 months ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
lzheng
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Modify the SPDY v1 hack to only advertise v1 and not v2 over NPN. There is no point in advertising a protocol that won't work. (When in v1 mode, the protocol frames will all say v1, which, to a v2 server will likely be broken BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/http_network_layer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Belshe
10 years, 4 months ago (2010-08-05 15:48:47 UTC) #1
lzheng
10 years, 4 months ago (2010-08-05 16:20:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698