Issue 3072021: [Mac] Tweaks to the Wrench menu buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3072021: [Mac] Tweaks to the Wrench menu buttons. (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Tweaks to the Wrench menu buttons. This changes the two-tone background to an even gradient and changes the push state of the buttons to use the blue selected menu item color. BUG=none TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55007

Patch Set 1 #

Total comments: 3

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -2 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View	7 chunks	+45 lines, -2 lines	0 comments	Download
A	chrome/browser/cocoa/wrench_menu_button_cell.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/wrench_menu_button_cell.mm	View	1 chunk	+46 lines, -0 lines	3 comments	Download
A	chrome/browser/cocoa/wrench_menu_button_cell_unittest.mm	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

10 years, 4 months ago (2010-08-04 19:16:36 UTC) #2

LGTM

http://codereview.chromium.org/3072021/diff/1/4
File chrome/browser/cocoa/wrench_menu_button_cell.mm (right):

http://codereview.chromium.org/3072021/diff/1/4#newcode17
chrome/browser/cocoa/wrench_menu_button_cell.mm:17: frame = NSInsetRect(frame,
0, 1);
0.0 and 1.0?

http://codereview.chromium.org/3072021/diff/1/4#newcode20
chrome/browser/cocoa/wrench_menu_button_cell.mm:20: // strong, un-anti-aliased
border.
Could you get something similar by insetting by a fractional pixel instead? I
never understand quite when you need to do that.

http://codereview.chromium.org/3072021/diff/1/4#newcode23
chrome/browser/cocoa/wrench_menu_button_cell.mm:23: frame = NSInsetRect(frame,
1, 1);
1.0, 1.0?

Expand Messages | Collapse Messages