Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 3071022: Reland 54771 (and 54795) To enable TCP Preconnection by default... (Closed)

Created:
10 years, 4 months ago by jar (doing other things)
Modified:
9 years, 6 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Reland 54771 (and 54795) To enable TCP Preconnection by default I added defensive code in ClientSocketHandle::ReleaseSocket(), which should preclude the crash that was reported on the stability bot. I added a second call to ReleaseSocket() from ~ClientSocketHandle to ensure that we updated the related ClientSocket when we are torn down. r=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55071

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -38 lines) Patch
M chrome/browser/browser_main.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/net/preconnect.h View 1 2 3 4 5 6 7 3 chunks +19 lines, -5 lines 0 comments Download
M chrome/browser/net/preconnect.cc View 1 2 3 4 5 6 7 6 chunks +43 lines, -21 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 2 3 4 5 6 7 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/client_socket.h View 1 2 3 4 5 6 7 2 chunks +38 lines, -0 lines 0 comments Download
A net/socket/client_socket.cc View 1 2 3 4 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
M net/socket/client_socket_handle.h View 1 2 3 4 5 6 7 1 chunk +10 lines, -1 line 0 comments Download
MM net/socket/client_socket_handle.cc View 7 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
10 years, 4 months ago (2010-08-04 23:23:16 UTC) #1
Mike Belshe
You mention in your comment that you updated ~ClientSocketHandle, but you forgot to add ClientSocketHandle.cc ...
10 years, 4 months ago (2010-08-04 23:52:04 UTC) #2
jar (doing other things)
This includes the (formely) missing client_socket_handle.cc
10 years, 4 months ago (2010-08-05 03:53:26 UTC) #3
Mike Belshe
10 years, 4 months ago (2010-08-05 16:13:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698